CodeVetter · Repo Unpack · Contributor handoff
pydantic/pydantic
Start from the schema boundary and trace the specific public API before changing shared internals. Tests and CI were inspected, not executed, so future implementation work must establish its own validation results. The investigation covered selected source, tests, configuration, and every listed workflow entrypoint, but remains a bounded inventory. Keep version coupling, deferred construction, output types, and validation bypasses explicit in acceptance criteria.
- Read architecture.md, ModelMetaclass/complete_model_class, GenerateSchema, and the relevant Rust validator first; executable core schemas and exported JSON Schema are separate contracts.
- Keep Pydantic's compatible-core constant, root dependency pin, and Cargo version synchronized; this checkout declares Pydantic 2.14.0b2 with core 2.49.0.
- Prefer the repository uv workspace and existing Makefile targets; root formatting is Ruff with 120-column lines, single quotes, Python 3.10 targeting, and Google-style docstrings.
- For authorized changes, begin with focused model, serialization, call, or plugin tests; broader existing checks include make test, make lint, and Rust cargo test. These commands and CI were inspected only, not executed here.
- Static typing needs separate checks: Mypy integration is skipped without --test-mypy, and Makefile exposes distinct Mypy-plugin, Pyright, Mypy, and Pyrefly targets.
- Preserve delayed-build and forced-rebuild semantics: unresolved annotations can install mocks, model_rebuild resolves namespaces under a lock, and forced completion prevents reuse of stale compiled objects.
- Acceptance tests should preserve BaseModel JSON str versus TypeAdapter JSON bytes, alias/name validation guards, unvalidated construction/copy updates, and RootModel's rejection of extra configuration.
- Contributor policy targets new features at v2 and requires understanding AI-assisted changes; the assignment workflow closes non-exempt PRs whose referenced closing issues are not assigned to the author, while allowing PRs with no closing references through that check.