CodeVetter · Repo Unpack · Risk map
redwoodjs/redwood
The observations below identify security-sensitive boundaries and correctness hotspots in source, not confirmed vulnerabilities. Authentication and filesystem APIs rely on application configuration and authorization decisions, while dynamic module loading trusts installed or compiled code. Several explicit comments document unfinished behavior, including CSRF validation and job runtime enforcement. Runtime severity, exploitability, and whole-repository coverage remain unverified.
- DbAuthHandler._validateCsrf compares the session token to the request header but is explicitly labeled 'not used yet'; login responses nevertheless issue a CSRF token and encrypted session cookie.
- useRequireAuth catches authentication errors, clears currentUser, and still calls handlerFn; its development warning instructs applications to call requireAuth inside their own handlers.
- The Lambda GraphQL wrapper logs execution exceptions and returns an error body with statusCode 200, accompanied by a source comment saying it should be 500.
- Worker awaits Executor.perform in-process and explicitly leaves maxRuntime timeout enforcement as a TODO requiring a separate process; maxRuntime is currently passed to adapter.find.
- FileSystemStorage.read/remove accept caller-supplied paths directly, and save accepts a path override; these methods contain no local check confining operations to baseDir.
- CLI plugin auto-install defaults to true, and loadPluginPackage can install and dynamically import a configured package; the source also notes installed/requested version mismatch handling is incomplete.
- Vite publishes explicitly included and REDWOOD_ENV_ prefixed environment values in browser definitions and HTML substitutions; naming/configuration determines which values cross the server-to-browser boundary.
- lambdaLoader keys imported functions by basename and assigns them into a shared registry; hypothesis: two discovered files with the same basename could collide, which should be checked before changing discovery rules. (inferred)
- Fastify server setup imports a Babel-generated __rw_graphqlOptions export from the application's compiled GraphQL function; this creates a coupling between the build transform and runtime registration.
- The todo fixture retains a GraphQL bootstrap importing makeServices/makeMergedSchema from @redwoodjs/api and passing schema, whereas test-project uses @redwoodjs/graphql-server with sdls/services/loggerConfig; it should not be treated as a current server setup recipe.
- UrlSigner deliberately supports nonexpiring signatures when no expiresInMs is supplied and compares signatures with ordinary string inequality; expiration and comparison behavior are review points at this access boundary.
- Job loaders join stored jobPath to the compiled jobs directory and dynamically import the result; protecting persisted invocation metadata is consequently part of the worker's code-execution trust boundary.