CodeVetter · Repo Unpack · Risk map
pallets/werkzeug
The important trust boundaries are request-body resource consumption, debugger command execution, forwarded headers, filesystem paths, and outbound proxy connections. The observations below describe source behavior and configuration responsibilities, not confirmed vulnerabilities. Compatibility branches and documentation drift also deserve attention during maintenance. The example's persistence race is an explicitly labeled hypothesis requiring separate verification.
- Request.max_content_length defaults to None, get_data reads the body into memory, and URL-encoded parsing does not apply multipart memory/part limits; applications or upstream servers must establish a total-body limit.
- The debugger intentionally evaluates Python commands: dispatch requires evalex, a known frame, matching command secret, and PIN trust, then execute_command checks host trust before frame.eval; production deployment docs prohibit the development debugger/server.
- ProxyFix's trusted counts select values from the right of forwarded-header lists; trusting client-controlled positions can alter remote address, scheme, host, or mount prefix.
- safe_join checks path names rather than symlinks or filesystem trust; send_from_directory requires a trusted base directory, while FileStorage.save opens a supplied path directly in write mode.
- ProxyMiddleware creates outbound HTTP/HTTPS connections to configured targets, forwards filtered request headers and body chunks, and turns OSError into BadGateway; target and TLS configuration are sensitive integration boundaries.
- The reloader spawns the current Python interpreter with inherited environment and descriptors, setting WERKZEUG_RUN_MAIN; run_simple transfers the server descriptor through WERKZEUG_SERVER_FD.
- Hypothesis: concurrent Shortly.insert_url calls for the same URL can both miss the reverse mapping and allocate separate identifiers because GET, INCR, and the two SET operations are separate calls; this was not reproduced. (inferred)
- Security documentation has a concrete default mismatch: generate_password_hash's PBKDF2 description says 600000 iterations, while DEFAULT_PBKDF2_ITERATIONS and test_pbkdf2 use 1000000; callers should rely on the actual stored method string.