CodeVetter · Repo Unpack · Contributor handoff
pmndrs/zustand
Start with the affected runtime module and its API/type contract before editing. Tests and CI were inspected, not executed, so all suggested validation remains future work when execution is authorized. Keep changes focused on source and meaningful regressions, and treat initialization, middleware ordering, hydration generations, and generated declarations as coupled contracts.
- Read vanilla.ts and react.ts first for store/hook changes, and read the affected middleware alongside middlewareTypes.test.tsx when altering wrapped APIs or overloads.
- Source imports use explicit .ts extensions and type-only imports; tsconfig enforces strictness, exact optional properties, unchecked-index awareness, verbatim module syntax, and isolated declarations.
- Preserve setState replacement semantics and the retained initial snapshot; replacing a state object can remove actions, and synchronously reading get() during initialization precedes state assignment.
- For persistence changes, read both sync/async suites and preserve generation checks around state application, completion, errors, and clearStorage; storage clearing must remain distinct from live-state reset.
- When execution is authorized, use the existing test:spec script to target affected suites and test:types for signature changes; inspected CI also requests format, lint, and build checks, but none ran during this investigation.
- Packaging edits require reading Rollup aliases/replacements and declaration postprocessing; generated ESM declarations change extensions and module-augmentation paths.
- Root type/lint scopes exclude the examples; inspect their own manifests and configs for example work, and account for demo's Zustand 4 dependency instead of assuming it tests local Zustand 5.
- CONTRIBUTING.md requests focused changes, regression tests, formatting, conventional commits, and discussion-led contributions rather than direct contributor PRs; publication and deployment are separate CI operations, not local validation steps.