CodeVetter · Repo Unpack · Contributor handoff
gin-gonic/gin
Begin changes at the relevant public API and follow its ownership boundaries into implementation and tests. Preserve response commitment, pooled-context lifetime, route-registration timing, and build-tag compatibility. Tests and CI were inspected, not executed, and this bounded brief supplies no passing results or measured performance claims. Future verification commands below are guidance for an authorized execution phase, not actions performed during this investigation.
- Read constructors, route-chain construction, dispatch, and Context reset/Next together before changing routing or middleware; their shared indices and pooled state determine execution behavior.
- Preserve QUERY outside IRoutes and Any unless intentionally changing compatibility; corresponding tests document both contracts.
- Inspect both binding.go and binding_nomsgpack.go for shared binding changes: build-tag alternatives duplicate interfaces, globals, and dispatch logic, with differing binder variable declarations.
- Keep ShouldBind error-return behavior distinct from MustBindWith's committed 400/413 behavior; Render errors are recorded and abort the chain without automatically replacing status.
- For upload changes, retain the existing-directory permission contract and distinguish optional directory permissions from output-file creation; review caller destination handling alongside filename guidance.
- Use relevant named Go tests first when execution is authorized; inspect make test's four-package filter before relying on it for internal-package changes. Tests and CI here were inspected, not executed.
- Configure replacement json.API before serving and restore global codec state in tests, as TestCustomJsonCodec does; ginS wrappers share a lazily initialized singleton Engine.
- Contribution guidance asks for tests covering changes and new-feature documentation in docs/doc.md; inspect the configured CI tag/race matrix and lint exclusions rather than assuming one default test run covers every variant.